<html>
<head><meta charset="utf-8"><title>Perf triage 2020-11-17 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html">Perf triage 2020-11-17</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="217198961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217198961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217198961">(Nov 18 2020 at 21:26)</a>:</h4>
<p>have the perf triage happened this week?</p>



<a name="217199161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217199161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217199161">(Nov 18 2020 at 21:28)</a>:</h4>
<p>I completely forgot about it</p>



<a name="217199221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217199221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217199221">(Nov 18 2020 at 21:29)</a>:</h4>
<p>Cc <span class="user-mention" data-user-id="224872">@Ryan Levick</span> in case you have some time tonight</p>



<a name="217199326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217199326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217199326">(Nov 18 2020 at 21:30)</a>:</h4>
<p>(or <span class="user-mention" data-user-id="118594">@ecstatic-morse</span>)</p>



<a name="217199366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217199366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217199366">(Nov 18 2020 at 21:30)</a>:</h4>
<p>I can try to get it done tonight though so we can have it for triage tomorrow, regardless, will ping you once we have something</p>



<a name="217199776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217199776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217199776">(Nov 18 2020 at 21:34)</a>:</h4>
<p>If I no one does it, I can take care of it tomorrow morning European time.</p>



<a name="217217388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217217388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217217388">(Nov 19 2020 at 00:55)</a>:</h4>
<p>I ended up running out of time to do this, so if <span class="user-mention" data-user-id="224872">@Ryan Levick</span> you do it tomorrow that'd be great. Otherwise I will take a stab at it in the morning as well.</p>



<a name="217259487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217259487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217259487">(Nov 19 2020 at 11:57)</a>:</h4>
<p>ohh cool</p>



<a name="217259529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217259529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217259529">(Nov 19 2020 at 11:57)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> if you do the report before <time datetime="2020-11-19T15:00:00Z">2020-11-19T12:00:00-03:00</time>, please let me know so we can include it in today's compiler team agenda meeting</p>



<a name="217260297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217260297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217260297">(Nov 19 2020 at 12:06)</a>:</h4>
<p>I’m about to sit down to do it now</p>



<a name="217262484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217262484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217262484">(Nov 19 2020 at 12:32)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> on of the perf regressions was in a roll up. It's my understanding that rollups _should_ be composed of PRs that don't affect performance (among other things). Should we make special note of this? Should we try to find what in particular in the roll up caused the issue?</p>



<a name="217262517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217262517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217262517">(Nov 19 2020 at 12:32)</a>:</h4>
<p>Special note is not usually necessary</p>



<a name="217262534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217262534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217262534">(Nov 19 2020 at 12:33)</a>:</h4>
<p>(well, good to mark it in the report)</p>



<a name="217262569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217262569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217262569">(Nov 19 2020 at 12:33)</a>:</h4>
<p>Yes trying to identify the exact cause is good</p>



<a name="217262640"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217262640" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217262640">(Nov 19 2020 at 12:34)</a>:</h4>
<p>If you have a link to the regression I can try and help - usually we can narrow pretty quickly to one or two PRs and ping authors on the rollup thread</p>



<a name="217263064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263064">(Nov 19 2020 at 12:39)</a>:</h4>
<p>There are actually three rollup threads in the performance regression group</p>



<a name="217263108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263108">(Nov 19 2020 at 12:39)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/78998">https://github.com/rust-lang/rust/issues/78998</a> <br>
<a href="https://github.com/rust-lang/rust/issues/79065">https://github.com/rust-lang/rust/issues/79065</a><br>
<a href="https://github.com/rust-lang/rust/issues/79128">https://github.com/rust-lang/rust/issues/79128</a></p>



<a name="217263307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263307">(Nov 19 2020 at 12:41)</a>:</h4>
<p>Looking</p>



<a name="217263408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263408">(Nov 19 2020 at 12:42)</a>:</h4>
<p>Do you have the regression links handy?</p>



<a name="217263431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263431">(Nov 19 2020 at 12:43)</a>:</h4>
<p>The actual perf results you mean?</p>



<a name="217263493"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263493" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263493">(Nov 19 2020 at 12:43)</a>:</h4>
<p><a href="https://perf.rust-lang.org/compare.html?start=9722952f0bed5815cb22cb4878be09fb39f92804&amp;end=e80ee05bfc135d7d800f3fcc89bc005d6858cd9b&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=9722952f0bed5815cb22cb4878be09fb39f92804&amp;end=e80ee05bfc135d7d800f3fcc89bc005d6858cd9b&amp;stat=instructions:u</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=361c4ea22486557ec50c4fc6a93d60e7476ecbea&amp;end=75042566d1c90d912f22e4db43b6d3af98447986&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=361c4ea22486557ec50c4fc6a93d60e7476ecbea&amp;end=75042566d1c90d912f22e4db43b6d3af98447986&amp;stat=instructions:u</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=54508a26eb0595eb8417a4643f2ee572d6ca33d3&amp;end=efcb3b39203a0d54269ca274601b8f73207fe10d&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=54508a26eb0595eb8417a4643f2ee572d6ca33d3&amp;end=efcb3b39203a0d54269ca274601b8f73207fe10d&amp;stat=instructions:u</a></p>



<a name="217263963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217263963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217263963">(Nov 19 2020 at 12:48)</a>:</h4>
<p>First one looks like the destructuring assignment to me</p>



<a name="217264154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264154">(Nov 19 2020 at 12:50)</a>:</h4>
<p>Second is probably the normalization of function types, but unsure.</p>



<a name="217264225"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264225" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264225">(Nov 19 2020 at 12:51)</a>:</h4>
<p>Last one might be just noise, but probably caused by the storage duration PR if not.</p>



<a name="217264242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264242">(Nov 19 2020 at 12:51)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> ^</p>



<a name="217264264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264264">(Nov 19 2020 at 12:51)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> is this perf "improvement" significant enough to mention: <a href="https://perf.rust-lang.org/compare.html?start=98d66340d6e63eda115afc8b0da1d87965881936&amp;end=361c4ea22486557ec50c4fc6a93d60e7476ecbea&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=98d66340d6e63eda115afc8b0da1d87965881936&amp;end=361c4ea22486557ec50c4fc6a93d60e7476ecbea&amp;stat=instructions:u</a></p>



<a name="217264475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264475">(Nov 19 2020 at 12:53)</a>:</h4>
<p>I think no</p>



<a name="217264545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217264545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217264545">(Nov 19 2020 at 12:54)</a>:</h4>
<p>Ok good. That's what I thought</p>



<a name="217265043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265043">(Nov 19 2020 at 12:58)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> what makes you say the last one might be noise. The perf impact is fairly large</p>



<a name="217265189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265189">(Nov 19 2020 at 13:00)</a>:</h4>
<p>ctfe stress is pretty sensitive to seemingly unrelated changes</p>



<a name="217265252"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265252" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265252">(Nov 19 2020 at 13:00)</a>:</h4>
<p>But it's unclear</p>



<a name="217265309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265309">(Nov 19 2020 at 13:01)</a>:</h4>
<p>It looks like we should have perf results since then so the graph might give you a better idea</p>



<a name="217265326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265326">(Nov 19 2020 at 13:01)</a>:</h4>
<p>(on mobile so can't look easily)</p>



<a name="217265856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217265856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217265856">(Nov 19 2020 at 13:06)</a>:</h4>
<p>In general it looks like this period had some big perf wins but was filled by a lot of small perf regressions: <a href="https://perf.rust-lang.org/compare.html?start=cf9cf7c923eb01146971429044f216a3ca905e06&amp;end=c919f490bbcd2b29b74016101f7ec71aaa24bdbb&amp;stat=instructions%3Au">https://perf.rust-lang.org/compare.html?start=cf9cf7c923eb01146971429044f216a3ca905e06&amp;end=c919f490bbcd2b29b74016101f7ec71aaa24bdbb&amp;stat=instructions%3Au</a></p>



<a name="217266084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217266084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217266084">(Nov 19 2020 at 13:08)</a>:</h4>
<p>Yeah, that's not atypical</p>



<a name="217266267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217266267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217266267">(Nov 19 2020 at 13:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> do you know of any nags. I've not yet seen any</p>



<a name="217266582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217266582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217266582">(Nov 19 2020 at 13:12)</a>:</h4>
<p>No, nothing outstanding</p>



<a name="217266611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217266611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217266611">(Nov 19 2020 at 13:12)</a>:</h4>
<p>Here's the first draft: <a href="https://github.com/rust-lang/rustc-perf/pull/794">https://github.com/rust-lang/rustc-perf/pull/794</a></p>



<a name="217266647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217266647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217266647">(Nov 19 2020 at 13:12)</a>:</h4>
<p>Let me know if there's anything you think I should go more in-depth on</p>



<a name="217267039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217267039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217267039">(Nov 19 2020 at 13:16)</a>:</h4>
<p>I think it looks good. Did you leave comments on the rollups pinging authors of suspected PRs yet?</p>



<a name="217267331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217267331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217267331">(Nov 19 2020 at 13:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> just merged the PR</p>



<a name="217267334"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217267334" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217267334">(Nov 19 2020 at 13:19)</a>:</h4>
<p>No I didn't. I'm happy to do so</p>



<a name="217267349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217267349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217267349">(Nov 19 2020 at 13:19)</a>:</h4>
<p>That would be great!</p>



<a name="217267392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217267392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217267392">(Nov 19 2020 at 13:19)</a>:</h4>
<p>If you look at a past report there should be examples in some of the rollups, if that's helpful</p>



<a name="217296201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Perf%20triage%202020-11-17/near/217296201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Perf.20triage.202020-11-17.html#217296201">(Nov 19 2020 at 16:40)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> sorry that I couldn't say this properly before the meeting but thanks for doing the report <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>